Add CoreProfile to database #5170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
group/backend
ogenstad
force-pushed
the
pog-store-coreprofile-in-db
branch
from
b168098 to
1dc8334
Compare
ogenstad
force-pushed
the
pog-store-coreprofile-in-db
branch
from
1dc8334 to
9418095
Compare
CodSpeed Performance ReportMerging #5170 will not alter performanceComparing Summary
|
dgarros
approved these changes
Dec 10, 2024
|
I opened #5178 as a follow up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue of the workers being out of sync after the initial startup. It seems unclear if there was a reason why we didn't store the CoreProfile schema node in the database, my guess is that this was something that just happened when we removed the other profiles from the database.
As
CoreProfilewasn't loaded to the database, we'd have a different instance on the first gunicorn worker compared to the three whereCoreProfilegets generated automatically during initialization. There might be additional cleanups that could be done around this object but I'm guessing that would require changes to other tests and this is something we can look at later.